Repository navigation
[CI][Docs] Add scheduled Sphinx link check for docs - #8273
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation maintenance process by implementing an automated link verification system. By integrating a scheduled CI workflow and refining Sphinx configuration, the project can proactively detect and resolve broken external links, ensuring the reliability of the documentation for all users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a scheduled Sphinx link check to the documentation workflow, including configuration in docs/source/conf.py and local usage instructions in the developer guide. Feedback was provided regarding adherence to the repository's PR title and summary style guide, increasing the linkcheck_timeout to prevent flaky CI failures, and correcting a potentially overly specific IP address in the linkcheck_ignore list.
| # sites render anchors dynamically, which makes anchor checks flaky in CI. | ||
| linkcheck_anchors = False | ||
| linkcheck_retries = 2 | ||
| linkcheck_timeout = 10 |
There was a problem hiding this comment.
A timeout of 10 seconds is quite low for external link checks and may lead to flaky CI failures when remote servers are slow to respond. Increasing this to the Sphinx default of 30 seconds or higher is recommended for better stability.
| linkcheck_timeout = 10 | |
| linkcheck_timeout = 30 |
References
- Avoid low timeouts in CI configurations to prevent flaky builds caused by external network latency.
911515e to
e5be2b6
Compare
5c753e0 to
60ab261
Compare
b0b4ac3 to
e8081bb
Compare
Signed-off-by: MrZ20 <2609716663@qq.com>
### What this PR does / why we need it? This PR adds a scheduled documentation link check workflow to catch broken links and unexpected redirects in the Sphinx docs on a regular basis. Main changes: - add a GitHub Actions workflow to run `make -C docs linkcheck` weekly and on manual trigger - configure Sphinx `linkcheck` options in `docs/source/conf.py` to reduce flaky CI failures - document how to run the docs link check locally and where to find the generated reports - fix link in docs This helps us detect documentation link issues earlier and makes docs maintenance more proactive and repeatable. In docs/source/community/**contributors.md**, delete: ``` | 17 | [@dependabot[bot]](https://github.com/dependabot[bot]) | 2025/02/27 | [a5564ed](vllm-project@a5564ed) | | 149 | [@invalid-email-address](https://github.com/invalid-email-address) | 2025/09/14 | [c9da5de](vllm-project@c9da5de) | | 207 | [@Copilot](https://github.com/Copilot) | 2025/11/11 | [24bca67](vllm-project@24bca67) | | 292 | [@nomewang](https://github.com/nomewang) | 2026/01/12 | [348cdf9](vllm-project@348cdf9) | ``` ### Does this PR introduce _any_ user-facing change? No user-facing runtime change. This only affects documentation validation and contributor workflow. ### How was this patch tested? - Verified the workflow definition and Sphinx linkcheck-related configuration changes - Added local usage instructions in: - `docs/source/developer_guide/contribution/testing.md` If needed, the check can be run locally with: ```bash make -C docs linkcheck SPHINXOPTS="-W --keep-going" ``` - vLLM version: - vLLM main: https://github.com/vllm-project/vllm/commit/v0.19.0 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
### What this PR does / why we need it? This PR adds a scheduled documentation link check workflow to catch broken links and unexpected redirects in the Sphinx docs on a regular basis. Main changes: - add a GitHub Actions workflow to run `make -C docs linkcheck` weekly and on manual trigger - configure Sphinx `linkcheck` options in `docs/source/conf.py` to reduce flaky CI failures - document how to run the docs link check locally and where to find the generated reports - fix link in docs This helps us detect documentation link issues earlier and makes docs maintenance more proactive and repeatable. In docs/source/community/**contributors.md**, delete: ``` | 17 | [@dependabot[bot]](https://github.com/dependabot[bot]) | 2025/02/27 | [a5564ed](vllm-project@a5564ed) | | 149 | [@invalid-email-address](https://github.com/invalid-email-address) | 2025/09/14 | [c9da5de](vllm-project@c9da5de) | | 207 | [@Copilot](https://github.com/Copilot) | 2025/11/11 | [24bca67](vllm-project@24bca67) | | 292 | [@nomewang](https://github.com/nomewang) | 2026/01/12 | [348cdf9](vllm-project@348cdf9) | ``` ### Does this PR introduce _any_ user-facing change? No user-facing runtime change. This only affects documentation validation and contributor workflow. ### How was this patch tested? - Verified the workflow definition and Sphinx linkcheck-related configuration changes - Added local usage instructions in: - `docs/source/developer_guide/contribution/testing.md` If needed, the check can be run locally with: ```bash make -C docs linkcheck SPHINXOPTS="-W --keep-going" ``` - vLLM version: - vLLM main: https://github.com/vllm-project/vllm/commit/v0.19.0 --------- Signed-off-by: MrZ20 <2609716663@qq.com>
### What this PR does / why we need it? This PR adds a scheduled documentation link check workflow to catch broken links and unexpected redirects in the Sphinx docs on a regular basis. Main changes: - add a GitHub Actions workflow to run `make -C docs linkcheck` weekly and on manual trigger - configure Sphinx `linkcheck` options in `docs/source/conf.py` to reduce flaky CI failures - document how to run the docs link check locally and where to find the generated reports - fix link in docs This helps us detect documentation link issues earlier and makes docs maintenance more proactive and repeatable. In docs/source/community/**contributors.md**, delete: ``` | 17 | [@dependabot[bot]](https://github.com/dependabot[bot]) | 2025/02/27 | [a5564ed](vllm-project@a5564ed) | | 149 | [@invalid-email-address](https://github.com/invalid-email-address) | 2025/09/14 | [c9da5de](vllm-project@c9da5de) | | 207 | [@Copilot](https://github.com/Copilot) | 2025/11/11 | [24bca67](vllm-project@24bca67) | | 292 | [@nomewang](https://github.com/nomewang) | 2026/01/12 | [348cdf9](vllm-project@348cdf9) | ``` ### Does this PR introduce _any_ user-facing change? No user-facing runtime change. This only affects documentation validation and contributor workflow. ### How was this patch tested? - Verified the workflow definition and Sphinx linkcheck-related configuration changes - Added local usage instructions in: - `docs/source/developer_guide/contribution/testing.md` If needed, the check can be run locally with: ```bash make -C docs linkcheck SPHINXOPTS="-W --keep-going" ``` - vLLM version: - vLLM main: https://github.com/vllm-project/vllm/commit/v0.19.0 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: PiratePai <416932041@qq.com>
### What this PR does / why we need it? This PR adds a scheduled documentation link check workflow to catch broken links and unexpected redirects in the Sphinx docs on a regular basis. Main changes: - add a GitHub Actions workflow to run `make -C docs linkcheck` weekly and on manual trigger - configure Sphinx `linkcheck` options in `docs/source/conf.py` to reduce flaky CI failures - document how to run the docs link check locally and where to find the generated reports - fix link in docs This helps us detect documentation link issues earlier and makes docs maintenance more proactive and repeatable. In docs/source/community/**contributors.md**, delete: ``` | 17 | [@dependabot[bot]](https://github.com/dependabot[bot]) | 2025/02/27 | [a5564ed](vllm-project@a5564ed) | | 149 | [@invalid-email-address](https://github.com/invalid-email-address) | 2025/09/14 | [c9da5de](vllm-project@c9da5de) | | 207 | [@Copilot](https://github.com/Copilot) | 2025/11/11 | [24bca67](vllm-project@24bca67) | | 292 | [@nomewang](https://github.com/nomewang) | 2026/01/12 | [348cdf9](vllm-project@348cdf9) | ``` ### Does this PR introduce _any_ user-facing change? No user-facing runtime change. This only affects documentation validation and contributor workflow. ### How was this patch tested? - Verified the workflow definition and Sphinx linkcheck-related configuration changes - Added local usage instructions in: - `docs/source/developer_guide/contribution/testing.md` If needed, the check can be run locally with: ```bash make -C docs linkcheck SPHINXOPTS="-W --keep-going" ``` - vLLM version: - vLLM main: https://github.com/vllm-project/vllm/commit/v0.19.0 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: yangzhe-2026 <yangzhe@isrc.iscas.ac.cn>
### What this PR does / why we need it? This PR adds a scheduled documentation link check workflow to catch broken links and unexpected redirects in the Sphinx docs on a regular basis. Main changes: - add a GitHub Actions workflow to run `make -C docs linkcheck` weekly and on manual trigger - configure Sphinx `linkcheck` options in `docs/source/conf.py` to reduce flaky CI failures - document how to run the docs link check locally and where to find the generated reports - fix link in docs This helps us detect documentation link issues earlier and makes docs maintenance more proactive and repeatable. In docs/source/community/**contributors.md**, delete: ``` | 17 | [@dependabot[bot]](https://github.com/dependabot[bot]) | 2025/02/27 | [a5564ed](vllm-project@a5564ed) | | 149 | [@invalid-email-address](https://github.com/invalid-email-address) | 2025/09/14 | [c9da5de](vllm-project@c9da5de) | | 207 | [@Copilot](https://github.com/Copilot) | 2025/11/11 | [24bca67](vllm-project@24bca67) | | 292 | [@nomewang](https://github.com/nomewang) | 2026/01/12 | [348cdf9](vllm-project@348cdf9) | ``` ### Does this PR introduce _any_ user-facing change? No user-facing runtime change. This only affects documentation validation and contributor workflow. ### How was this patch tested? - Verified the workflow definition and Sphinx linkcheck-related configuration changes - Added local usage instructions in: - `docs/source/developer_guide/contribution/testing.md` If needed, the check can be run locally with: ```bash make -C docs linkcheck SPHINXOPTS="-W --keep-going" ``` - vLLM version: - vLLM main: https://github.com/vllm-project/vllm/commit/v0.19.0 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: ZhuQi-seu <zhuqi12@huawei.com>
### What this PR does / why we need it? This PR adds a scheduled documentation link check workflow to catch broken links and unexpected redirects in the Sphinx docs on a regular basis. Main changes: - add a GitHub Actions workflow to run `make -C docs linkcheck` weekly and on manual trigger - configure Sphinx `linkcheck` options in `docs/source/conf.py` to reduce flaky CI failures - document how to run the docs link check locally and where to find the generated reports - fix link in docs This helps us detect documentation link issues earlier and makes docs maintenance more proactive and repeatable. In docs/source/community/**contributors.md**, delete: ``` | 17 | [@dependabot[bot]](https://github.com/dependabot[bot]) | 2025/02/27 | [a5564ed](vllm-project@a5564ed) | | 149 | [@invalid-email-address](https://github.com/invalid-email-address) | 2025/09/14 | [c9da5de](vllm-project@c9da5de) | | 207 | [@Copilot](https://github.com/Copilot) | 2025/11/11 | [24bca67](vllm-project@24bca67) | | 292 | [@nomewang](https://github.com/nomewang) | 2026/01/12 | [348cdf9](vllm-project@348cdf9) | ``` ### Does this PR introduce _any_ user-facing change? No user-facing runtime change. This only affects documentation validation and contributor workflow. ### How was this patch tested? - Verified the workflow definition and Sphinx linkcheck-related configuration changes - Added local usage instructions in: - `docs/source/developer_guide/contribution/testing.md` If needed, the check can be run locally with: ```bash make -C docs linkcheck SPHINXOPTS="-W --keep-going" ``` - vLLM version: - vLLM main: https://github.com/vllm-project/vllm/commit/v0.19.0 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: nanxing <1014662416@qq.com>
### What this PR does / why we need it? This PR adds a scheduled documentation link check workflow to catch broken links and unexpected redirects in the Sphinx docs on a regular basis. Main changes: - add a GitHub Actions workflow to run `make -C docs linkcheck` weekly and on manual trigger - configure Sphinx `linkcheck` options in `docs/source/conf.py` to reduce flaky CI failures - document how to run the docs link check locally and where to find the generated reports - fix link in docs This helps us detect documentation link issues earlier and makes docs maintenance more proactive and repeatable. In docs/source/community/**contributors.md**, delete: ``` | 17 | [@dependabot[bot]](https://github.com/dependabot[bot]) | 2025/02/27 | [a5564ed](vllm-project@a5564ed) | | 149 | [@invalid-email-address](https://github.com/invalid-email-address) | 2025/09/14 | [c9da5de](vllm-project@c9da5de) | | 207 | [@Copilot](https://github.com/Copilot) | 2025/11/11 | [24bca67](vllm-project@24bca67) | | 292 | [@nomewang](https://github.com/nomewang) | 2026/01/12 | [348cdf9](vllm-project@348cdf9) | ``` ### Does this PR introduce _any_ user-facing change? No user-facing runtime change. This only affects documentation validation and contributor workflow. ### How was this patch tested? - Verified the workflow definition and Sphinx linkcheck-related configuration changes - Added local usage instructions in: - `docs/source/developer_guide/contribution/testing.md` If needed, the check can be run locally with: ```bash make -C docs linkcheck SPHINXOPTS="-W --keep-going" ``` - vLLM version: - vLLM main: https://github.com/vllm-project/vllm/commit/v0.19.0 --------- Signed-off-by: MrZ20 <2609716663@qq.com>
### What this PR does / why we need it? This PR adds a scheduled documentation link check workflow to catch broken links and unexpected redirects in the Sphinx docs on a regular basis. Main changes: - add a GitHub Actions workflow to run `make -C docs linkcheck` weekly and on manual trigger - configure Sphinx `linkcheck` options in `docs/source/conf.py` to reduce flaky CI failures - document how to run the docs link check locally and where to find the generated reports - fix link in docs This helps us detect documentation link issues earlier and makes docs maintenance more proactive and repeatable. In docs/source/community/**contributors.md**, delete: ``` | 17 | [@dependabot[bot]](https://github.com/dependabot[bot]) | 2025/02/27 | [1c2c5d9](vllm-project@1c2c5d9) | | 149 | [@invalid-email-address](https://github.com/invalid-email-address) | 2025/09/14 | [c9da5de](vllm-project@c9da5de) | | 207 | [@Copilot](https://github.com/Copilot) | 2025/11/11 | [24bca67](vllm-project@24bca67) | | 292 | [@nomewang](https://github.com/nomewang) | 2026/01/12 | [348cdf9](vllm-project@348cdf9) | ``` ### Does this PR introduce _any_ user-facing change? No user-facing runtime change. This only affects documentation validation and contributor workflow. ### How was this patch tested? - Verified the workflow definition and Sphinx linkcheck-related configuration changes - Added local usage instructions in: - `docs/source/developer_guide/contribution/testing.md` If needed, the check can be run locally with: ```bash make -C docs linkcheck SPHINXOPTS="-W --keep-going" ``` - vLLM version: - vLLM main: https://github.com/vllm-project/vllm/commit/v0.19.0 --------- Signed-off-by: MrZ20 <2609716663@qq.com>
What this PR does / why we need it?
This PR adds a scheduled documentation link check workflow to catch broken links
and unexpected redirects in the Sphinx docs on a regular basis.
Main changes:
make -C docs linkcheckweekly and on manual triggerlinkcheckoptions indocs/source/conf.pyto reduce flaky CI failuresThis helps us detect documentation link issues earlier and makes docs maintenance
more proactive and repeatable.
In docs/source/community/contributors.md, delete:
Does this PR introduce any user-facing change?
No user-facing runtime change.
This only affects documentation validation and contributor workflow.
How was this patch tested?
docs/source/developer_guide/contribution/testing.mdIf needed, the check can be run locally with:
make -C docs linkcheck SPHINXOPTS="-W --keep-going"